Skip loading info.json into ext.data
#3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merci Zach. |
|
My group doesn't use the zarr option so no. We could add a test? and see if it works in the CI. |
|
maybe yes if you have time |
|
Based on tests passing it seems like zarr doesn't have this problem. Let me know if the test isn't too heavy. I personally think this is better. If we are reloading an analyzer we should check that it loads at least one extension as well, no? |
zm711
commented
Jun 20, 2024
| @@ -312,7 +325,7 @@ def test_extensions_sorting(): | |||
|
|
|||
| if __name__ == "__main__": | |||
| tmp_path = Path("test_SortingAnalyzer") | |||
| dataset = _get_dataset() | |||
| dataset = get_dataset() | |||
There was a problem hiding this comment.
This change is just because the function wasn't private above.
|
You are the heroe. |
samuelgarcia
approved these changes
Jun 20, 2024
alejoe91
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3041
Based on our discussion today. This patch is tested and working for
select_units.