Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize numba cross-correlation and extend correlograms.py docstrings and tests #3017

Merged
merged 24 commits into from
Jul 3, 2024
Merged

Optimize numba cross-correlation and extend correlograms.py docstrings and tests #3017

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
b8f8627
Add docstrings from other PR.
JoeZiminski Jun 11, 2024
b0dab65
Make astype copy=False.
JoeZiminski Jun 12, 2024
f906020
Add a few more notes and thoughts.
JoeZiminski Jun 12, 2024
3de3d9a
Continue playing with tests.
JoeZiminski Jun 19, 2024
73c7290
Fix edge issue on numpy and numba.
JoeZiminski Jun 19, 2024
dd371e0
Playing a little bit more comparing against old numba version.
JoeZiminski Jun 19, 2024
5391363
Continue hunting for solution to numpy left-bound.
JoeZiminski Jun 19, 2024
45be351
99% sure numpy version is fixed next doc reasoning.
JoeZiminski Jun 19, 2024
763f266
Add fix for left bin edge problem in numpy implementation.
JoeZiminski Jun 20, 2024
0d252d8
Fix up and add docstrings to final tests.
JoeZiminski Jun 20, 2024
f36d95b
Remove old numba implementation.
JoeZiminski Jun 20, 2024
67aa872
Tentatively remove the compute from spiketrain functions.
JoeZiminski Jun 20, 2024
4d4c4cd
Tentatively make some functions private.
JoeZiminski Jun 20, 2024
2c3eeb9
Remove some notes.
JoeZiminski Jun 20, 2024
09d67ab
Add back 'correlogram_for_one_segment' to __init__.py
JoeZiminski Jun 20, 2024
c86e4f0
Remove TODO
JoeZiminski Jun 20, 2024
6c2bb48
Final tidy ups.
JoeZiminski Jun 21, 2024
5ebb984
Move long docstrings to 'Notes' section.
JoeZiminski Jun 27, 2024
2a32b13
Fix bad grammer in docstring
JoeZiminski Jun 27, 2024
503cf1a
Fix weird space in the word 'window'
JoeZiminski Jun 27, 2024
5b5dbc8
Merge branch 'main' into optimize_numba_correlogram
samuelgarcia Jun 28, 2024
b1392ed
Rename clusters to units.
JoeZiminski Jul 2, 2024
2741273
Add formula to correlogram docstring description.
JoeZiminski Jul 2, 2024
a96821c
Rename spike_labels -> spike_unit_indices
JoeZiminski Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/spikeinterface/postprocessing/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,7 @@
from .correlograms import (
ComputeCorrelograms,
compute_correlograms,
compute_autocorrelogram_from_spiketrain,
compute_crosscorrelogram_from_spiketrain,
correlogram_for_one_segment,
compute_correlograms_numba,
compute_correlograms_numpy,
)

from .isi import (
Expand Down
Loading