Add tests for windows and mac #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
This is ready to go, let's discuss on the meeting tomorrow how to handle this. |
alejoe91
approved these changes
Jun 19, 2024
zm711
reviewed
Jun 19, 2024
src/spikeinterface/extractors/tests/test_datalad_downloading.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Zach McKenzie <[email protected]>
Co-authored-by: Zach McKenzie <[email protected]>
|
@h-mayorquin this is ready to merge? Or do I remember correctly that you needed to push another couple of changes? |
|
Let me actually fix the caches first in another PR. |
|
Ok @alejoe91 the caches are working:
This is ready to go. I will add now in another PR the logic for only running tests in modules that change or if core changes. |
|
Should we squash and merge? |
Yes, please. I will make them a bit faster with #3084 and once we feel comfortably after a while we can remove the current ubuntu specific workflow I hope. |
|
Thanks a lot for this monstruous effort. |
JoeZiminski
pushed a commit
to JoeZiminski/spikeinterface
that referenced
this pull request
Jun 26, 2024
* extend tests for windows and mac --------- Co-authored-by: Zach McKenzie <[email protected]> Co-authored-by: Chris Halcrow <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
JoeZiminski
pushed a commit
to JoeZiminski/spikeinterface
that referenced
this pull request
Jun 26, 2024
* extend tests for windows and mac --------- Co-authored-by: Zach McKenzie <[email protected]> Co-authored-by: Chris Halcrow <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full testing suit, right now is set as a push for debugging. Will be a cron job per week once we are sure it works.