Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update curation module to use sorting argument rather than parent_sorting #2922

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Update curation module to use sorting argument rather than parent_sorting #2922

merged 5 commits into from
Jun 5, 2024

Conversation

zm711
Copy link
Collaborator

@zm711 zm711 commented May 29, 2024

No description provided.

@zm711
Copy link
Collaborator Author

zm711 commented May 30, 2024

@DradeAW for discussion!

Fix _kwargs

@zm711
Copy link
Collaborator Author

zm711 commented May 30, 2024

After discussion we are good to do the hard break still need to fix the _kwargs.

@alejoe91 alejoe91 added refactor Refactor of code, with no change to functionality packaging Related to packaging/style labels May 30, 2024
@alejoe91 alejoe91 added the hackathon-24 Contributions during the SpikeInterface Hackathon May 24 label Jun 1, 2024
@alejoe91
Copy link
Member

alejoe91 commented Jun 3, 2024

@zm711 ready to review?

@zm711
Copy link
Collaborator Author

zm711 commented Jun 3, 2024

Oops. I opened all my PRs as drafts because the button was on draft mode. Haha.

Yeah as long as you're okay with a breaking change this is good to go. Sam and Aurelien said they were okay with it, but the alternative would be to make sorting optional and then do a deprecation instead.

@zm711 zm711 marked this pull request as ready for review June 3, 2024 16:06
@alejoe91
Copy link
Member

alejoe91 commented Jun 3, 2024

Oops. I opened all my PRs as drafts because the button was on draft mode. Haha.

Yeah as long as you're okay with a breaking change this is good to go. Sam and Aurelien said they were okay with it, but the alternative would be to make sorting optional and then do a deprecation instead.

Let's break! 1.0 here we come :)

@zm711
Copy link
Collaborator Author

zm711 commented Jun 4, 2024

We have conflicts now. I can work on this on Friday unless you want to just do this before than.

@alejoe91
Copy link
Member

alejoe91 commented Jun 4, 2024

I can fix it ;)

@alejoe91 alejoe91 merged commit 3c58fca into SpikeInterface:main Jun 5, 2024
11 checks passed
@alejoe91
Copy link
Member

alejoe91 commented Jun 5, 2024

Grazie Zach!

@samuelgarcia
Copy link
Member

Merci Zach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejoe91 alejoe91 alejoe91 approved these changes

Assignees
No one assigned
Labels
hackathon-24 Contributions during the SpikeInterface Hackathon May 24 packaging Related to packaging/style refactor Refactor of code, with no change to functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zm711 @alejoe91 @samuelgarcia