fixed bug in add_suffix and added test #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-mayorquin
approved these changes
May 29, 2024
There was a problem hiding this comment.
@alejoe91 somehow this was adding double dots to the files. It was producing file_path..raw instead of file_path.raw .
@nikhilchandra added a basic test for it.
It looks good to me.
samuelgarcia
approved these changes
May 30, 2024
alejoe91
added
the
hackathon-24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug wherein the add_suffix function was adding two dots to the filename instead of just one. For example, add_suffix('myfile', ['raw','bin','path']) returned "myfile..raw" instead of "myfile.raw". I have corrected this bug and also added a new test in test_core_tools.py.