Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic curation with metrics #2918

Draft
wants to merge 197 commits into
base: main
Choose a base branch
from
Draft

Automatic curation with metrics #2918

wants to merge 197 commits into from

Conversation

anoushkajain
Copy link

@anoushkajain anoushkajain commented May 29, 2024 •
edited
Loading

Solves #2479

@alejoe91 alejoe91 added the curation Related to curation module label May 30, 2024
jakeswann1 and others added 17 commits May 30, 2024 14:47
@jakeswann1
Cleaned notebook
f232864
@jakeswann1
Class and function for model based classification
4c5d335
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f3dabd3 
for more information, see https://pre-commit.ci
@jakeswann1
Removed notebook
88bb8b4
@jakeswann1
Parameter checking for classification
66f9098
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c411d7c 
for more information, see https://pre-commit.ci
@jakeswann1
Cleaned
c143e30
@jakeswann1
Draft tests
c4fb884
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
564e5ac 
for more information, see https://pre-commit.ci
@jakeswann1
Tests with pretrained toy pipeline
5c3e588
@jakeswann1
Merge branch 'curation_metrics' of https://github.com/anoushkajain/sp…
c408ff8 
…ikeinterface into curation_metrics
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
3a61bba 
for more information, see https://pre-commit.ci
@jakeswann1
pathing
f5b6998
@jakeswann1
Bug fixes & tests improvement
daec0c7
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
75b11ce 
for more information, see https://pre-commit.ci
@jakeswann1
Tests passing. Code to create test pipeline commented
dd846cf
@jakeswann1
small fix
57d5e32
@alejoe91 alejoe91 added the hackathon-24 Contributions during the SpikeInterface Hackathon May 24 label Jun 1, 2024
@alejoe91 alejoe91 changed the title automatic curation with metrics Automatic curation with metrics Jun 4, 2024
@chrishalcrow
respond to train_manual_curation review
4d0e259
@chrishalcrow
Refactor to use _get_computed_metrics for both CurationModelTrainer…
a939d81 
… and ModelBasedClassification
@chrishalcrow
Add tutorials to tutorials_custom_index
748c21d
@chrishalcrow
update train a model docs for new not-nan imputation
793a530
@chrishalcrow
oups
19c0990
@chrishalcrow
Little bits
f69d2f0
@chrishalcrow
add hfh logo
8dacf2a
@chrishalcrow
start responding to test comments
830a977
@chrishalcrow
add test documentation
0eb8751
@chrishalcrow
Merge branch 'main' into curation_metrics
37746e0
@chrishalcrow
Change qm_params to metric_params
c14b5d7
@chrishalcrow
Change metrics_kwargs to metric_params and add backwards compat f…
7585cdd 
…or loading models
@chrishalcrow
lil bugs for backwards compat
955ca72
@chrishalcrow
Refactor to take advantage of unified quality and template metrics
233d598
@chrishalcrow
Add links at start and end of train_a_model and upload_a_model docs
7b7323e
@chrishalcrow
Make generalised _format_metric_dataframe function
46681f8
@chrishalcrow
Update docs
52ac6a0
@chrishalcrow
Write metric names for csv mode, and don't check params if not in mod…
fee5f5b 
…el_info
@chrishalcrow
Update csv model_info to match analyzer model_info file
be79a83
@chrishalcrow
Merge branch 'main' into curation_metrics
77b8c81
@chrishalcrow
add docstring and delete a test
c6739df
@chrishalcrow
Update so csv can use subset of metrics
6aaf01f
@chrishalcrow
Change lists to distributions in default_classifier_search_spaces
59fad3f
@chrishalcrow
Add scoring_method for sorting best models
493ba4e
@chrishalcrow
Fix tests
832b4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishalcrow chrishalcrow chrishalcrow left review comments

@JoeZiminski JoeZiminski JoeZiminski left review comments

@alejoe91 alejoe91 alejoe91 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
curation Related to curation module hackathon-24 Contributions during the SpikeInterface Hackathon May 24
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anoushkajain @jakeswann1 @alejoe91 @RobertoDF @JoeZiminski @chrishalcrow @robyngreene