-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools for Generation of Hybrid recordings #2436
Conversation
for more information, see https://pre-commit.ci
…rface into hybrid_raw_clustering
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This PR depends on #2410 |
…e into hybrid_raw_clustering
I am very fascinated by this PR and the somewhat mysterious 'Hybrid' recordings, sounds cool! Could you extend the PR message with an explanation to the naive (me) 😄 ? |
Ready for final review here. See How To docs here: https://spikeinterface--2436.org.readthedocs.build/en/2436/how_to/benchmark_with_hybrid_recordings.html |
I was tagged, but I can't find where. Happy to comment on something if my opinion was desired. Just got an alert this morning, but now looking I can't find it :) |
It was about naming. Now one of the parameter is |
Cool, I think it is confusing right now because we have two arguments |
@zm711 we need to know if the provided templates are already scaled or not, so we don't want a verb IMO, so I'm leaning towards |
Then yes I think that |
I like that! |
Thank you all for the input! I think this will super important for future benchmarks. @JoeZiminski see updated PR description :) Merging! |
Cheers, that's awesome! Look forward to trying it |
This PR adds to the generation module the possibility to create hybrid recordings. These start from an existing recording and inject known units for benchmarking.
In particular, the user has can retrieve templates from a template database or estimate them from an initial spike sorting output.
The templates can be manipulated with selection, rescalilng and relocation to generate hybrid recordings of jincreasing complexity.
Importantly, a pre-eetimated motion can be used to inject spikes following the existing drift in the recording.
A how to page to showcase all these options is available here: https://spikeinterface--2436.org.readthedocs.build/en/2436/how_to/benchmark_with_hybrid_recordings.html