Remove legacy mode for generate_recording

[h-mayorquin]

The time has come.

There is nothing like the joy of deprecation and getting rid of old code.

Courtesy of Dall-e

[zm711]

Someone should really explain to Dall-e that it is really bad for the spines of books to lay flat like that.

[DradeAW]

Here you're not deprecating but removing the function, or have I misunderstood?

[alejoe91]

it was already called legacy, so it was kind of born deprecated

[DradeAW]

I was talking about the title of the PR, which sounds ambiguous to me.

I might be mistaking, but I thought:

• Deprecating = We advise not to use, we will not support / drop this later
• Removing = You can't use it anymore

[alejoe91]

Ah I see. Yes let's change the PR name :)

[h-mayorquin]

@DradeAW You are correct. It should be removing. I actually read a discussiong today in the python forums about it, mea culpa.

[samuelgarcia]

I am OK with this but I think we decided to keep 2 versions after a deprecation no ?
here it is only one.

[h-mayorquin]

@samuelgarcia no, we added a removing version at that point in time. Maybe you are confusing this with the modes of the GeneratorRecording? This is about the in-memory version of generate_recording the utility function.

[zm711]

Since we are here two typos in the docstring that can be fixed.