Avoid duplicated template and quality metric names #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejoe91
added
postprocessing
h-mayorquin
reviewed
Nov 15, 2023
| @@ -60,7 +60,7 @@ def _set_params( | |||
| metric_names += get_multi_channel_template_metric_names() | |||
| metrics_kwargs = metrics_kwargs or dict() | |||
| params = dict( | |||
| metric_names=[str(name) for name in metric_names], | |||
| metric_names=[str(name) for name in np.unique(metric_names)], | |||
There was a problem hiding this comment.
If this is a list maybe you can use set?
There was a problem hiding this comment.
e.g: {str(name) for name in metric_names}
There was a problem hiding this comment.
well it needs to be a list!
There was a problem hiding this comment.
Yeah, it could also be:
[[str(name) for name in set(metric_names)]
But it probably does not matter for this size anyway : )
h-mayorquin
approved these changes
Nov 15, 2023
|
yes, especially if you use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In principle, the user can set duplicated metrics name. This simple PR makes a unique of the metric names to avoid duplication in the output dataframes