Legacy mode for circus 2 to ease comparison with circus 1 #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yger
changed the title
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Sweet! Have you made some benchmarks with SC1? |
|
Yes, it was the whole point, and the good news is that this is in line with SC1, giving similar results. This is a building brick for our next paper on the components :-) |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
This branch is bringing quite a lot a modifications but only to the files owned and used by circus2. The key point is to have a clustering very similar to the one of circus1, such that we can properly compare everything w.r.t the new clustering of SC2. The matching engine has also been consolidated with exhaustive comparison on real recordings |
zm711
reviewed
Nov 17, 2023
Co-authored-by: Zach McKenzie <[email protected]>
Co-authored-by: Zach McKenzie <[email protected]>
Co-authored-by: Zach McKenzie <[email protected]>
Co-authored-by: Zach McKenzie <[email protected]>
|
Thanks a lot for the comments! |
Co-authored-by: Garcia Samuel <[email protected]>
for more information, see https://pre-commit.ci
samuelgarcia
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a legacy mode to circus 2, in order to ease the comparison with circus 1. When legacy is True in the clustering, we will use a clustering very similar to the one performed by circus 1, and thus with performances that should be in line