Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement when counting num spikes #2198

Closed
wants to merge 2 commits into from
Closed

Improvement when counting num spikes #2198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65c5024
Improvement when counting num spikes
DradeAW Nov 13, 2023
3601564
Merge branch 'main' into num_spikes_vector_fast
DradeAW Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/spikeinterface/core/basesorting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,14 +280,7 @@ def count_num_spikes_per_unit(self) -> dict:
"""
num_spikes = {}

if self._cached_spike_trains is not None:
for unit_id in self.unit_ids:
n = 0
for segment_index in range(self.get_num_segments()):
st = self.get_unit_spike_train(unit_id=unit_id, segment_index=segment_index)
n += st.size
num_spikes[unit_id] = n
else:
if self._cached_spike_vector is not None:
spike_vector = self.to_spike_vector()
unit_indices, counts = np.unique(spike_vector["unit_index"], return_counts=True)
for unit_index, unit_id in enumerate(self.unit_ids):
Expand All @@ -296,6 +289,13 @@ def count_num_spikes_per_unit(self) -> dict:
num_spikes[unit_id] = counts[idx]
else: # This unit has no spikes, hence it's not in the counts array.
num_spikes[unit_id] = 0
else:
for unit_id in self.unit_ids:
n = 0
for segment_index in range(self.get_num_segments()):
st = self.get_unit_spike_train(unit_id=unit_id, segment_index=segment_index)
n += st.size
num_spikes[unit_id] = n

return num_spikes

Expand Down