Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WaveformExtractor.is_extension --> has_extension #2158

Merged
merged 10 commits into from
Nov 15, 2023
Merged

WaveformExtractor.is_extension --> has_extension #2158

merged 10 commits into from
Nov 15, 2023

Conversation

DradeAW
Copy link
Contributor

@DradeAW DradeAW commented Nov 2, 2023

Fixed typo

@DradeAW
Copy link
Contributor Author

DradeAW commented Nov 2, 2023

This is done,

I added a deprecation warning to is_extension

@alejoe91 alejoe91 added the core Changes to core module label Nov 2, 2023
h-mayorquin
h-mayorquin requested changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the timeline of deprecations explicit. I have seen many stuff that says it will be deprecated but I don't know when it was introduced.

I suggest that you mark this has deprecated in two versions down the line.

src/spikeinterface/core/waveform_extractor.py Outdated Show resolved Hide resolved
@samuelgarcia
Copy link
Member

OK for me

h-mayorquin
h-mayorquin approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, for me as well
Thanks @DradeAW

@alejoe91 alejoe91 merged commit e4c5d11 into SpikeInterface:main Nov 15, 2023
9 checks passed
@DradeAW DradeAW deleted the wvf_extension_typo branch November 17, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zm711 zm711 zm711 left review comments

@alejoe91 alejoe91 alejoe91 approved these changes

@h-mayorquin h-mayorquin h-mayorquin approved these changes

Assignees
No one assigned
Labels
core Changes to core module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DradeAW @samuelgarcia @h-mayorquin @alejoe91 @zm711