Fix open ephys probe loading and unify probeinterface import syntax #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejoe91
added
bug
alejoe91
changed the title
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| import numpy as np | |||
|
|
|||
| from probeinterface import read_prb, write_prb | |||
| import probeinterface as pi | |||
There was a problem hiding this comment.
I am not really sure that "pi" is a good alias!!!!
why not keeping flat import ?
There was a problem hiding this comment.
is the same as import spikeinterface as si
There was a problem hiding this comment.
plus it's like that in many other files..let's unify this
samuelgarcia
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI errors occurring due to this pribeinterface PR: SpikeInterface/probeinterface#206