Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port some legacy widgets in new API #2016

Merged
merged 9 commits into from
Sep 21, 2023
Merged

Port some legacy widgets in new API #2016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
46c4ada
Port plot_agreement_matrix to new widgets API
samuelgarcia Sep 19, 2023
e49071e
Port plot_confusion_matrix to new API.
samuelgarcia Sep 19, 2023
3d79295
port plot_probe_map() to new widgets API
samuelgarcia Sep 19, 2023
dd368ed
Merge branch 'main' of github.com:SpikeInterface/spikeinterface into …
samuelgarcia Sep 19, 2023
4501289
Port plot_raster() to new API.
samuelgarcia Sep 19, 2023
625ff5e
Oups.
samuelgarcia Sep 19, 2023
84051d1
oups
samuelgarcia Sep 21, 2023
eaaffd0
Merge branch 'main' into port_legacy_widget
samuelgarcia Sep 21, 2023
85c7755
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/spikeinterface/widgets/_legacy_mpl_widgets/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
# basics
# from .timeseries import plot_timeseries, TracesWidget
from .rasters import plot_rasters, RasterWidget
from .probemap import plot_probe_map, ProbeMapWidget

# isi/ccg/acg
from .isidistribution import plot_isi_distribution, ISIDistributionWidget

Expand All @@ -15,9 +10,6 @@
# units on probe
from .unitprobemap import plot_unit_probe_map, UnitProbeMapWidget

# comparison related
from .confusionmatrix import plot_confusion_matrix, ConfusionMatrixWidget
from .agreementmatrix import plot_agreement_matrix, AgreementMatrixWidget
from .multicompgraph import (
plot_multicomp_graph,
MultiCompGraphWidget,
Expand Down
77 changes: 0 additions & 77 deletions src/spikeinterface/widgets/_legacy_mpl_widgets/probemap.py
View file
Open in desktop

This file was deleted.

120 changes: 0 additions & 120 deletions src/spikeinterface/widgets/_legacy_mpl_widgets/rasters.py
View file
Open in desktop

This file was deleted.

48 changes: 0 additions & 48 deletions src/spikeinterface/widgets/_legacy_mpl_widgets/tests/test_widgets_legacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,44 +43,6 @@ def setUp(self):
def tearDown(self):
pass

# def test_timeseries(self):
# sw.plot_timeseries(self._rec, mode='auto')
# sw.plot_timeseries(self._rec, mode='line', show_channel_ids=True)
# sw.plot_timeseries(self._rec, mode='map', show_channel_ids=True)
# sw.plot_timeseries(self._rec, mode='map', show_channel_ids=True, order_channel_by_depth=True)

def test_rasters(self):
sw.plot_rasters(self._sorting)

def test_plot_probe_map(self):
sw.plot_probe_map(self._rec)
sw.plot_probe_map(self._rec, with_channel_ids=True)

# TODO
# def test_spectrum(self):
# sw.plot_spectrum(self._rec)

# TODO
# def test_spectrogram(self):
# sw.plot_spectrogram(self._rec, channel=0)

# def test_unitwaveforms(self):
# w = sw.plot_unit_waveforms(self._we)
# unit_ids = self._sorting.unit_ids[:6]
# sw.plot_unit_waveforms(self._we, max_channels=5, unit_ids=unit_ids)
# sw.plot_unit_waveforms(self._we, radius_um=60, unit_ids=unit_ids)

# def test_plot_unit_waveform_density_map(self):
# unit_ids = self._sorting.unit_ids[:3]
# sw.plot_unit_waveform_density_map(self._we, unit_ids=unit_ids, max_channels=4)
# sw.plot_unit_waveform_density_map(self._we, unit_ids=unit_ids, radius_um=50)
#
# sw.plot_unit_waveform_density_map(self._we, unit_ids=unit_ids, radius_um=25, same_axis=True)
# sw.plot_unit_waveform_density_map(self._we, unit_ids=unit_ids, max_channels=2, same_axis=True)

# def test_unittemplates(self):
# sw.plot_unit_templates(self._we)

def test_plot_unit_probe_map(self):
sw.plot_unit_probe_map(self._we, with_channel_ids=True)
sw.plot_unit_probe_map(self._we, animated=True)
Expand Down Expand Up @@ -120,12 +82,6 @@ def test_plot_peak_activity_map(self):
sw.plot_peak_activity_map(self._rec, with_channel_ids=True)
sw.plot_peak_activity_map(self._rec, bin_duration_s=1.0)

def test_confusion(self):
sw.plot_confusion_matrix(self._gt_comp, count_text=True)

def test_agreement(self):
sw.plot_agreement_matrix(self._gt_comp, count_text=True)

def test_multicomp_graph(self):
msc = sc.compare_multiple_sorters([self._sorting, self._sorting, self._sorting])
sw.plot_multicomp_graph(msc, edge_cmap="viridis", node_cmap="rainbow", draw_labels=False)
Expand All @@ -150,8 +106,6 @@ def test_sorting_performance(self):
mytest.setUp()

# ~ mytest.test_timeseries()
# ~ mytest.test_rasters()
mytest.test_plot_probe_map()
# ~ mytest.test_unitwaveforms()
# ~ mytest.test_plot_unit_waveform_density_map()
# mytest.test_unittemplates()
Expand All @@ -169,8 +123,6 @@ def test_sorting_performance(self):
# ~ mytest.test_plot_drift_over_time()
# ~ mytest.test_plot_peak_activity_map()

# mytest.test_confusion()
# mytest.test_agreement()
# ~ mytest.test_multicomp_graph()
#  mytest.test_sorting_performance()

Expand Down
Loading