Skip to content

Commit

Permalink
try and skip the artifact step.
Browse files Browse the repository at this point in the history
  • Loading branch information
JoeZiminski committed Jun 26, 2024
1 parent 229d761 commit 9ea5583
Showing 1 changed file with 9 additions and 43 deletions.
52 changes: 9 additions & 43 deletions .github/workflows/test_kilosort4.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@ on:
- main

jobs:
fetch-versions:
versions:
runs-on: ubuntu-latest
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
steps:
- name: Checkout repository
uses: actions/checkout@v2
Expand All @@ -28,64 +30,35 @@ jobs:
- name: Fetch package versions from PyPI
run: |
python .github/scripts/check_kilosort4_releases.py
echo $(pwd)
pwd
ls .github/scripts
echo ${{ github.workspace }}
shell: bash

- name: Upload versions file
uses: actions/upload-artifact@v2
with:
name: versions
path: ${{ github.workspace }}/.github/scripts/kilosort4-latest-version.json
configure:
needs: fetch-versions
runs-on: ubuntu-latest
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
steps:
- name: Checkout to repository
uses: actions/checkout@v2

- name: Download versions file
uses: actions/download-artifact@v2
with:
name: versions # Name of the artifact to download
path: ${{ github.workspace }} # Directory to download the artifact to

- name: Set matrix data
id: set-matrix
run: |
pwd
ls .github/scripts
ls
ls ${{ github.workspace }}
echo "matrix=$(jq -c . < kilosort4-latest-version.json)" >> $GITHUB_OUTPUT
echo "matrix=$(jq -c . < .github/scripts/kilosort4-latest-version.json)" >> $GITHUB_OUTPUT
test:
needs: configure
needs: versions
name: ${{ matrix.ks_version }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
python-version: ["3.12"] # TODO: "3.9", # Lower and higher versions we support
os: [ubuntu-latest] # TODO: macos-13, windows-latest,
ks_version: ${{ fromJson(needs.configure.outputs.matrix) }} # TODO: add / build from pypi based on Christians PR
os: [ubuntu-latest]
ks_version: ${{ fromJson(needs.versions.outputs.matrix) }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v2

- name: Setup Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}

- name: Install packages
# TODO: maybe dont need full?
run: |
pip install -e .[test]
# git config --global user.email "[email protected]"
# git config --global user.name "CI Almighty"
# pip install tabulate
shell: bash

- name: Install Kilosort
Expand All @@ -94,13 +67,6 @@ jobs:
shell: bash

- name: Run new kilosort4 tests
# run: chmod +x .github/test_kilosort4.sh
# TODO: figure out the paths to be able to run this by calling the file directly
run: |
pytest -k test_kilosort4_new --durations=0
shell: bash

# TODO: pip install -e .[full,dev] is failing #
#The conflict is caused by:
# spikeinterface[docs] 0.101.0rc0 depends on datalad==0.16.2; extra == "docs"
# spikeinterface[test] 0.101.0rc0 depends on datalad>=1.0.2; extra == "test"

0 comments on commit 9ea5583

Please sign in to comment.