Add packaging to CI dependency.

On branch add_kilosort4_wrapper_tests
SpikeInterface · Jun 27, 2024 · 9bc1897 · 9bc1897
1 parent 21caaf9
commit 9bc1897
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/.github/scripts/check_kilosort4_releases.py b/.github/scripts/check_kilosort4_releases.py
@@ -16,7 +16,6 @@ def get_pypi_versions(package_name):
     data = response.json()
     versions = list(sorted(data["releases"].keys()))
     versions = [ver for ver in versions if parse(ver) >= parse("4.0.5")]
-    versions.pop(versions.index("4.0.4"))
     return versions
 
 

diff --git a/.github/workflows/test_kilosort4.yml b/.github/workflows/test_kilosort4.yml
@@ -25,7 +25,7 @@ jobs:
 
       - name: Install dependencies
         run: |
-          pip install requests
+          pip install requests packaging
 
       - name: Fetch package versions from PyPI
         run: |

diff --git a/src/spikeinterface/sorters/external/kilosort4.py b/src/spikeinterface/sorters/external/kilosort4.py
@@ -163,7 +163,7 @@ def _run_from_folder(cls, sorter_output_folder, params, verbose):
 
             logging.basicConfig(level=logging.INFO)
 
-        if cls.get_sorter_version() < version.parse("4.0.5"):
+        if version.parse(cls.get_sorter_version()) < version.parse("4.0.5"):
             raise RuntimeError(
                 "Kilosort versions before 4.0.5 are not supported"
                 "in SpikeInterface. "