Skip to content

Commit

Permalink
Merge pull request #3360 from h-mayorquin/improve_docstring_of_ground…
Browse files Browse the repository at this point in the history
…_truth_comparison

Clarify meaning of `delta_time` in  `compare_sorter_to_ground_truth`
  • Loading branch information
alejoe91 authored Sep 4, 2024
2 parents bd67da8 + 149c5d4 commit 519c7c7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/spikeinterface/comparison/paircomparisons.py
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,9 @@ class GroundTruthComparison(BasePairSorterComparison):
tested_name : : str, default: None
The name of sorter 2
delta_time : float, default: 0.4
Number of ms to consider coincident spikes
Number of ms to consider coincident spikes.
This means that two spikes are considered simultaneous if they are within `delta_time` of each other or
mathematically abs(spike1_time - spike2_time) <= delta_time.
match_score : float, default: 0.5
Minimum agreement score to match units
chance_score : float, default: 0.1
Expand Down
2 changes: 2 additions & 0 deletions src/spikeinterface/sorters/runsorter.py
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,9 @@ def run_sorter_local(
# only classmethod call not instance (stateless at instance level but state is in folder)
folder = SorterClass.initialize_folder(recording, folder, verbose, remove_existing_folder)
SorterClass.set_params_to_folder(recording, folder, sorter_params, verbose)
# This writes parameters and recording to binary and could ideally happen in the host
SorterClass.setup_recording(recording, folder, verbose=verbose)
# This NEEDS to happen in the docker because of dependencies
SorterClass.run_from_folder(folder, raise_error, verbose)
if with_output:
sorting = SorterClass.get_result_from_folder(folder, register_recording=True, sorting_info=True)
Expand Down

0 comments on commit 519c7c7

Please sign in to comment.