Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to weather command #377

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Access to weather command #377

wants to merge 7 commits into from

Conversation

masterdoctor
Copy link

No description provided.

@MiniDigger
Copy link
Contributor

could you like, not? I told you last time and I will tell you again:

instead of slowing down the development and testing of spigot 1.13 by creating useless PRs, why don't you hop on the server an search for bugs like the rest is doing?

stop trying to be sneaky and getting access to permissions you shouldn't have.

@masterdoctor
Copy link
Author

Shit, sorry, that was an honest mistake.

@masterdoctor
Copy link
Author

I genuinely just wanted the weather permission.

@yannicklamprecht
Copy link
Contributor

yannicklamprecht commented Mar 4, 2018

You are fucking lying. The second time.

Edit: Now you fucked up the file.

users:

is needed.

@Pokechu22
Copy link
Contributor

This does actually look like an honest mistake to me after further looking. Their first pull request, #371, was a joke (and is now labeled as such, though it wasn't then but they said so in chat). They did that from their master branch.

This one is also from their master branch, and it looks like as such the original commit was included by accident (probably not fully understanding how git works). They attempted to update their fork (masterdoctor/SpigotCraft#2), but since pull requests merge instead of replacing, the original joke commit is still present. The actual change that was supposed to be made here, 39685df, is also present.

@masterdoctor
Copy link
Author

@ysl3000 Seriously...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants