Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add abort on timeout #1137

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add abort on timeout #1137

wants to merge 3 commits into from

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Apr 17, 2024 •
edited
Loading

This PR has a few fixes.

  1. Adds an abort if spin4 can be pinged but does then timesout
  2. Now has the scamp.boot copied from Spinnman
  3. Changed the hard coded scamp version
  4. Got two tests to work by changing the expected values.
  • I do not know why these values changed with the new scamp only that they did!

@Christian-B Christian-B added the blocker Do not release when one of these is open! label Apr 17, 2024
@Christian-B
Copy link
Member Author

This was tested by http://apollo.cs.man.ac.uk:8080/blue/organizations/jenkins/Integration%20Tests/detail/abort/1/pipeline/
Which got past the Java build crashing because spin4 pinged but would not turn on.

That then failed for other reasons which may point out why spin4 is misbehaving

@coveralls
Copy link

Coverage Status

coverage: 37.007% (+0.1%) from 36.875%
when pulling 19d724a on abort
into 22d7f46 on master.

@Christian-B Christian-B removed the blocker Do not release when one of these is open! label Apr 17, 2024
@Christian-B Christian-B mentioned this pull request Apr 18, 2024
Open
@Christian-B Christian-B added the blocker Do not release when one of these is open! label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rowleya rowleya

Labels
blocker Do not release when one of these is open!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Christian-B @coveralls @rowleya