Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

fix: always verify nonce, extract nonce from VP #76

Merged

Conversation

TimoGlastra
Copy link
Contributor

This PR makes a few improvements to the nonce extraction and verification process:

  • correctly extract nonce from SD-JWT, W3C JSON-LD or W3C JWT presentation. (I'll make a small follow up pr to clean up the SD-JWT nonce a bit once feat: add kb-jwt to sd-jwt SSI-SDK#183 is merged and released)
  • Fix the extraction of nonce values from set using array index (always returns undefined)
  • Make sure all presentations and id token and auth response use the same nonce
  • make sure nonce is always defined
  • check nonce against verifyOpts if provided

Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nklomp nklomp merged commit 1d27bdf into Sphereon-Opensource:develop Apr 24, 2024
1 check failed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants