feat/OIDF-51 - Implement Persistence Module #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcmelati
changed the title
zoemaas
reviewed
Jul 31, 2024
zoemaas
reviewed
Jul 31, 2024
|
Please do not merge yet. Imo the service layer needs to be decoupled into its own module, as all of that is still entirely KMP. Then other languages only have to hookup their API solution of choice to the service layer |
|
@nklomp implemented services module as per the message above |
jcmelati
added a commit
that referenced
this pull request
Aug 16, 2024
* chore: Removed redundant HTTPCache * chore: Uncommented ios targets back * refactor: refactored serializeNullable() * refactor: refactored deserialize() * refactor: refactored OutgoingEntityStatementContent.bytes() * refactor: refactored the tests to use assertEquals() * refactor: Changed the response body to jwt string * refactor: Removed unnecessary converter * feat: implement jwk persistence * fix: remove unused statement * fix: github CI * feat/OIDF-51 - Implement Persistence Module (#21) * merge oidf-7 * fix: models package * fix: openapi TrustMarkOwner property * fix: create account method return type * fix: rename file for consistency * feat: implement migration * fix: repository dependency * fix: add missing trailing new line * feat: implement services module * fix: package path * fix: remove unused file * fix: add missing entity to openapi spec * feat: persist generated keys * fix: typo * fix: missing deps * fix: ci docker command * fix: dependency * fix: remove unnecessary statement * feat: abstract jwk to its own module * feat: encrypt private keys when saving to database * feat: add note to README regarding usage of Local KMS in prod envs * fix: adapt key encryption test cases for when APP_KEY is null * fix: adjust function name * fix: add kotlin-js-store to gitignore * fix: clean common gradle file * fix: disable android build * fix: remove js implementation from services * feat: implement Subordinate repository (#29) * feat: implement federation server structure (#28) * feat: implement federation server structure * feat: implement Subordinate repository * fix: remove unused files * feat: implement federation list endpoint --------- Co-authored-by: Zoe Maas <[email protected]>
jcmelati
added a commit
that referenced
this pull request
Aug 16, 2024
* feat: Implemented KMS, JWKS generation and JWT sign * fix: Test dependencies * feat: Created sign and verify jwt functions * refactor: Added trailing new line to the files * fix: Removed some targets temporarily to fix build issues. * refactor: made the second paramenter of functions a Map without default value and refactored the key generation * refactor: Fixed build issues and removed commented-out code * fix: Fixed failing test and null pointer exception * chore: Removed redundant HTTPCache * chore: Uncommented ios targets back * refactor: refactored serializeNullable() * refactor: refactored deserialize() * refactor: refactored OutgoingEntityStatementContent.bytes() * refactor: refactored the tests to use assertEquals() * refactor: Fixed dependencies and made the protectedHeader a param * refactor: Fixed code formatting * refactor: Changed the response body to jwt string * refactor: Removed unnecessary converter * refactor: Made JWT payload and header classes to be used as input * fix: add missing repositories for windows (#22) * fix: add missing repositories for windows * fix: update ci docker compose command * feat: implement jwk persistence * fix: remove unused statement * fix: github CI * feat/OIDF-51 - Implement Persistence Module (#21) * merge oidf-7 * fix: models package * fix: openapi TrustMarkOwner property * fix: create account method return type * fix: rename file for consistency * feat: implement migration * fix: repository dependency * fix: add missing trailing new line * feat: implement services module * fix: package path * fix: remove unused file * fix: add missing entity to openapi spec * feat: persist generated keys * fix: typo * fix: missing deps * fix: ci docker command * fix: dependency * fix: remove unnecessary statement * feat: abstract jwk to its own module * feat: encrypt private keys when saving to database * feat: add note to README regarding usage of Local KMS in prod envs * fix: adapt key encryption test cases for when APP_KEY is null * fix: adjust function name * fix: add kotlin-js-store to gitignore * fix: clean common gradle file * fix: disable android build * fix: remove js implementation from services * feat: implement federation server structure * feat: implement Subordinate repository * fix: remove unused files * feat: implement federation list endpoint * Feature/oidf 55 (#27) * feat: create servers dockerized containers * fix: only build jvm jars * fix: remove unnecessary env var * feat: update README with docker instructions * fix: further improve docker README * fix: adjust CI * fix: re-add missing env vars * fix: example app key lenght * fix: make docker wait for db to fully load * fix: pass db user to health check * fix: pass db user to health check * Feature/oidf 54 (#31) * feat: Implemented KMS, JWKS generation and JWT sign * fix: Test dependencies * feat: Created sign and verify jwt functions * refactor: Added trailing new line to the files * fix: Removed some targets temporarily to fix build issues. * refactor: made the second paramenter of functions a Map without default value and refactored the key generation * refactor: Fixed build issues and removed commented-out code * fix: Fixed failing test and null pointer exception * refactor: Fixed dependencies and made the protectedHeader a param * refactor: Fixed code formatting * refactor: Made JWT payload and header classes to be used as input * fix: add missing repositories for windows (#22) * fix: add missing repositories for windows * fix: update ci docker compose command * feat: implement jwk persistence * fix: remove unused statement * fix: github CI * fix: add missing entity to openapi spec * feat: persist generated keys * fix: typo * fix: remove unnecessary statement * feat: abstract jwk to its own module * feat: encrypt private keys when saving to database * feat: add note to README regarding usage of Local KMS in prod envs * fix: adapt key encryption test cases for when APP_KEY is null * fix: adjust function name * fix: add kotlin-js-store to gitignore * fix: clean common gradle file * fix: disable android build * fix: remove js implementation from services * feat: implement Subordinate repository (#29) * feat: implement federation server structure (#28) * feat: implement federation server structure * feat: implement Subordinate repository * fix: remove unused files * feat: implement federation list endpoint --------- Co-authored-by: Zoe Maas <[email protected]> * fix: make docker wait for db to fully load (#32) --------- Co-authored-by: Zoe Maas <[email protected]> Co-authored-by: John Melati <[email protected]>
jcmelati
added a commit
that referenced
this pull request
Aug 16, 2024
* feat: Implemented KMS, JWKS generation and JWT sign * fix: Test dependencies * feat: Created sign and verify jwt functions * refactor: Added trailing new line to the files * fix: Removed some targets temporarily to fix build issues. * refactor: made the second paramenter of functions a Map without default value and refactored the key generation * refactor: Fixed build issues and removed commented-out code * fix: Fixed failing test and null pointer exception * chore: Removed redundant HTTPCache * chore: Uncommented ios targets back * refactor: refactored serializeNullable() * refactor: refactored deserialize() * refactor: refactored OutgoingEntityStatementContent.bytes() * refactor: refactored the tests to use assertEquals() * refactor: Fixed dependencies and made the protectedHeader a param * refactor: Fixed code formatting * refactor: Changed the response body to jwt string * refactor: Removed unnecessary converter * refactor: Made JWT payload and header classes to be used as input * fix: add missing repositories for windows (#22) * fix: add missing repositories for windows * fix: update ci docker compose command * feat: implement jwk persistence * fix: remove unused statement * fix: github CI * feat/OIDF-51 - Implement Persistence Module (#21) * merge oidf-7 * fix: models package * fix: openapi TrustMarkOwner property * fix: create account method return type * fix: rename file for consistency * feat: implement migration * fix: repository dependency * fix: add missing trailing new line * feat: implement services module * fix: package path * fix: remove unused file * fix: add missing entity to openapi spec * feat: persist generated keys * fix: typo * fix: missing deps * fix: ci docker command * fix: dependency * fix: remove unnecessary statement * feat: abstract jwk to its own module * feat: encrypt private keys when saving to database * feat: add note to README regarding usage of Local KMS in prod envs * fix: adapt key encryption test cases for when APP_KEY is null * fix: adjust function name * fix: add kotlin-js-store to gitignore * fix: clean common gradle file * fix: disable android build * fix: remove js implementation from services * feat: implement federation server structure * feat: implement Subordinate repository * fix: remove unused files * feat: implement federation list endpoint * Feature/oidf 55 (#27) * feat: create servers dockerized containers * fix: only build jvm jars * fix: remove unnecessary env var * feat: update README with docker instructions * fix: further improve docker README * fix: adjust CI * fix: re-add missing env vars * fix: example app key lenght * fix: make docker wait for db to fully load --------- Co-authored-by: Zoe Maas <[email protected]>
jcmelati
added a commit
that referenced
this pull request
Aug 16, 2024
* feat: Implemented KMS, JWKS generation and JWT sign * fix: Test dependencies * feat: Created sign and verify jwt functions * refactor: Added trailing new line to the files * fix: Removed some targets temporarily to fix build issues. * refactor: made the second paramenter of functions a Map without default value and refactored the key generation * refactor: Fixed build issues and removed commented-out code * fix: Fixed failing test and null pointer exception * refactor: Fixed dependencies and made the protectedHeader a param * refactor: Fixed code formatting * refactor: Made JWT payload and header classes to be used as input * fix: add missing repositories for windows (#22) * fix: add missing repositories for windows * fix: update ci docker compose command * Feature/oidf 54 (#26) * chore: Removed redundant HTTPCache * chore: Uncommented ios targets back * refactor: refactored serializeNullable() * refactor: refactored deserialize() * refactor: refactored OutgoingEntityStatementContent.bytes() * refactor: refactored the tests to use assertEquals() * refactor: Changed the response body to jwt string * refactor: Removed unnecessary converter * feat: implement jwk persistence * fix: remove unused statement * fix: github CI * feat/OIDF-51 - Implement Persistence Module (#21) * merge oidf-7 * fix: models package * fix: openapi TrustMarkOwner property * fix: create account method return type * fix: rename file for consistency * feat: implement migration * fix: repository dependency * fix: add missing trailing new line * feat: implement services module * fix: package path * fix: remove unused file * fix: add missing entity to openapi spec * feat: persist generated keys * fix: typo * fix: missing deps * fix: ci docker command * fix: dependency * fix: remove unnecessary statement * feat: abstract jwk to its own module * feat: encrypt private keys when saving to database * feat: add note to README regarding usage of Local KMS in prod envs * fix: adapt key encryption test cases for when APP_KEY is null * fix: adjust function name * fix: add kotlin-js-store to gitignore * fix: clean common gradle file * fix: disable android build * fix: remove js implementation from services * feat: implement Subordinate repository (#29) * feat: implement federation server structure (#28) * feat: implement federation server structure * feat: implement Subordinate repository * fix: remove unused files * feat: implement federation list endpoint --------- Co-authored-by: Zoe Maas <[email protected]> --------- Co-authored-by: Zoe Maas <[email protected]> Co-authored-by: John Melati <[email protected]>
jcmelati
added a commit
that referenced
this pull request
Nov 1, 2024
* feat: Implemented KMS, JWKS generation and JWT sign * fix: Test dependencies * feat: Created sign and verify jwt functions * refactor: Added trailing new line to the files * fix: Removed some targets temporarily to fix build issues. * refactor: made the second paramenter of functions a Map without default value and refactored the key generation * refactor: Fixed build issues and removed commented-out code * fix: Fixed failing test and null pointer exception * chore: Removed redundant HTTPCache * chore: Uncommented ios targets back * refactor: refactored serializeNullable() * refactor: refactored deserialize() * refactor: refactored OutgoingEntityStatementContent.bytes() * refactor: refactored the tests to use assertEquals() * refactor: Fixed dependencies and made the protectedHeader a param * refactor: Fixed code formatting * refactor: Changed the response body to jwt string * refactor: Removed unnecessary converter * refactor: Made JWT payload and header classes to be used as input * fix: add missing repositories for windows (#22) * fix: add missing repositories for windows * fix: update ci docker compose command * feat: implement jwk persistence * fix: remove unused statement * fix: github CI * feat/OIDF-51 - Implement Persistence Module (#21) * merge oidf-7 * fix: models package * fix: openapi TrustMarkOwner property * fix: create account method return type * fix: rename file for consistency * feat: implement migration * fix: repository dependency * fix: add missing trailing new line * feat: implement services module * fix: package path * fix: remove unused file * fix: add missing entity to openapi spec * feat: persist generated keys * fix: typo * fix: missing deps * fix: ci docker command * fix: dependency * fix: remove unnecessary statement * feat: abstract jwk to its own module * chore: Trust Chain validation implementation * feat: encrypt private keys when saving to database * feat: add note to README regarding usage of Local KMS in prod envs * fix: adapt key encryption test cases for when APP_KEY is null * fix: adjust function name * fix: add kotlin-js-store to gitignore * fix: clean common gradle file * fix: disable android build * fix: Fixed merging issues * fix: Fixed coroutine issue * fix: Fixed build trust chain * fix: Fixed response headers * chore: Build the trust chain * refactor: Adjusted the trust chain validation to the models * refactor: Adjusted the trust chain validation with the local-kms and removed dead code * refactor: Removed service jvm folders and files * chore: Added trust chain structure test * refactor: Renamed op folder to validation * chore: Added trust chain validation test * chore: Added support to Subordinate Statements * chore: Trust Chain Validation refactoring - Separate Entity Configuration Statement from Subordinate Statements * chore: Trust Chain Validation refactoring - Build Trust Chain for testing * chore: Trust Chain Validation refactoring - Enabled JS in local-kms module, * chore: Trust Chain Validation refactoring - Moved client to its own module * chore: Trust Chain Validation fixed broken tests - * chore: Added jwk and jwt folder to openid-federation-common * chore: Fixed jsMain module and implemented tests * chore: Moved most part of the code to the common module * refactor: Moved retrieveJwk function to commonMain * refactor: Created JWT service that accepts callbacks and adjusted the code. * feat: implement resolve trust chain * fix: clean object mapping * fix: remove constraints temporarily * fix: extend trust chain build test * fix: trust chain resolve method * fix: get http engine automatically if none informed * feat: extract helper functions * feat: pass fetchservice as param * fix: ci * fix: js test * fix: fetch initialization * feat: implement client class * fix: oid client js export * fix: fetch class * fix: indentation * fix: js validateTrustChain return type * fix: resolve trust chain method name * feat: implement crypto module in client * feat: implement js verify function callback in test * fix: openapi jwk spec * fix: implement reference time on verify test * fix: code cleanup * fix: clean tests * fix: code cleanup * fix: move logger to own module * fix: make Trustchain a class to simplify dep injection * fix: verify function * fix: refactor helpers * fix: refactor * fix: refactor * fix: reorder authority hints to process trust anchors first * fix: add maxDepth parameter to trust chain resolution * fix: refactor jwk model structure * fix: subordinate jwks * fix: export ICryptoServiceCallback to JS * fix: pass callback constructors to oidf client js * chore: docker production updates * chore: docker production updates * chore: docker production updates * chore: revert docker compose ports updates * refactor: Refactored OIDF-Client according to mdoc-cbor-crypto-multiplatform * fixed: Fixed general bugs * refactor: Picking common dependencies from libs.versions.toml * refactor: Moved the trust chain to a callback * refactor: Created js tests * refactor: Created tests for jvm and js in their respective folders * fix: Libraries compatibility: openapi generator, kotlinx coroutines and ktor client * fix: Fixed issues with the implementation of the Default Trust Chain implementation. * refactor: Removed println(...) * refactor: Added the rest of the libraries to libs.versions.toml * chore: adding publishing configs * chore: adding publishing configs * chore: reverted db ports in compose * chore: fixed NEXUS_USERNAME env var * chore: fixed NPM_TOKEN env var * chore: open-api package rename due to npm issues * fix: Fixed the mangled filed names in JS * chore: also publish openid-federation-client * chore: added Default fetch service * chore: added generateTypeScriptDefinitions * feat: adjust federation fetch endpoint to new spec without iss param * fix: subordinate statement source endpoint --------- Co-authored-by: Zoe Maas <[email protected]> Co-authored-by: sanderPostma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.