Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/oidf 33 #15

Merged
merged 10 commits into from
Jul 19, 2024
Merged

Feature/oidf 33 #15

merged 10 commits into from
Jul 19, 2024

Conversation

zoemaas
Copy link
Contributor

@zoemaas zoemaas commented Jul 16, 2024

No description provided.

modules/openapi/build.gradle.kts Outdated Show resolved Hide resolved
Copy link
Contributor

@sanderPostma sanderPostma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I have a report on the openapi.yml, but those items are not serious enough for me to block this PR. Will post it in Jira

outputDir.set("$projectDir/build/generated")
configOptions.set(
mapOf(
"dateLibrary" to "java8",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still says java8 & jackson. That's not going to work on nodejs...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time please leave a message here when something is resolved or not applicable. (I am waiting for that)

@zoemaas zoemaas merged commit d149a5a into develop Jul 19, 2024
1 check passed
@zoemaas zoemaas deleted the feature/OIDF-33 branch July 19, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants