Feature/enable authorization code flow helpers #70
Conversation
…tion URI methods.
…ient initialization, update tests
|
Cool thanks. will have a look later today or probably tomorrow |
|
|
||
| return convertJsonToURI(queryObj, { | ||
| baseUrl: this._endpointMetadata.authorization_endpoint, | ||
| uriTypeProperties: ['redirect_uri', 'scope', 'authorization_details'], | ||
| version: this.version(), | ||
| uriTypeProperties: ['redirect_uri', 'scope', 'authorization_details', 'issuer_state'], |
There was a problem hiding this comment.
Will look later into whether leaving the version out doesn't have any side effects
There was a problem hiding this comment.
Based on the current convertJsonToURI implementation, excluding version param will do exactly what is needed in this case. Provided attributes have be added as query params. else statement does exactly that.
There was a problem hiding this comment.
Yeah, the problem however is that the convertJsonToURI is called from many places and it for sure needs the logic to distinguish between V11 and higher in other areas. What I will do is add an additional param that takes precedence over the version. From the first look of it you need it from the formPost method. So will use that param there
|
Hi @nklomp, just wanted to let you know that parts you commented on have been addressed. Let me know if there is anything else that you find concerning. |
…n, not only depending on versions, but also allowing to provide the mode explicitly. refs #70
|
@linasi Thanks for the PR. It is merged with a new param to make the encoding a bit more explicit |
flowTypeparameterOpenID4VCIClient.acquirePushedAuthorizationRequestURImethod to return a complete authorization URL that can be opened by the client. Just likecreateAuthorizationRequestUrldoes.clientIdthat was passed when constructingOpenID4VCIClientin subsequent calls.