CWALL-254 - FEATURE: added schemaValidation to CredentialRequestClient #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sksadjad
changed the title
nklomp
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Why are we adding schema validation options to a lib responsible for transport of credentials? The fact we are doing nothing with these options should also be a tell-tale sign.
Schema validation is credential format specific, not transport specific. So it should not live here.
The only potential option we could think about is an optional callback function registration for schema validation. When present call the callback with the received credentials in for instance an RP for OID4VP and holder for OID4VCI
|
created the ticket https://sphereon.atlassian.net/browse/SDK-33 for supporting callback function for oid4vp and oid4vci flows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added schemaValidation parameter to the CredentialRequestClient(Builder). This parameter is an enum with 3 values:
ALWAYS,NEVER,WHEN_PRESENT. When it's not configured in the builder (with available functions), we default toWHEN_PRESENT.