New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: client_id_scheme & default scope handling #142

Merged

nklomp merged 1 commit into Sphereon-Opensource:develop from auer-martin:fix/client_id_scheme

Aug 20, 2024

Contributor

auer-martin commented Aug 19, 2024

A small PR to fix the current client_id_scheme and default scope scope handling.

Removes the client_id_scheme from the client_metadata (should not be there)
Removes the cliend_id_scheme from the jwtIssuerX5C (because we also need the client_id_scheme when x5c is not used)
Add builder method for setting the client_id_scheme
Remove the openid default scope, it is not required.


          fix: client_id_scheme & default scope handling

c559618

nklomp approved these changes

View reviewed changes

Contributor

nklomp commented Aug 20, 2024

LGTM thanks

nklomp merged commit d4e90b0 into Sphereon-Opensource:develop

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet