New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scope and par fixes #133

Merged

nklomp merged 1 commit into Sphereon-Opensource:develop from TimoGlastra:fix/some-fixes

Jul 30, 2024

Collaborator

TimoGlastra commented Jul 30, 2024

This PR makes two changes:

prioritise authorization server metadata over issuer metadata for PAR requirements (Funke issuer adds it in authorization server metadata)
do not include openid scope if not included. I can't find in the specs where this is a requirement, and the funke PID issuer will not grant this scope. I think it makes more sense to let the user pass the scope openid if it wants this scope.


          fix: scope and par fixes

71e72aa

Signed-off-by: Timo Glastra <[email protected]>

nklomp reviewed

View reviewed changes

Contributor

nklomp left a comment

Just a small remark, not really needed

packages/client/lib/AuthorizationCodeClient.ts Show resolved Hide resolved

nklomp merged commit 105fc37 into Sphereon-Opensource:develop

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet