fix: oid4vci draft 13 typing #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
|
Yeah, the way Draft 13 was initially implemented and later partially/quickly corrected has been a bit of a $#@%-show. Let me have a look today |
nklomp
reviewed
Jul 19, 2024
nklomp
requested changes
Jul 19, 2024
Signed-off-by: Timo Glastra <[email protected]>
|
Resolved comments! |
nklomp
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the typing for draft 13 was not according to the spec. I also separated some type definitions per format so we have better type completion. We noticed when integrating draft 13 vs draft 11 in Credo that with draft 13 we lost a lost of format specific typing, which made using the library a lot easier. This aims to bring it back.
With the updates of the types I also discovered some bugs related to transformations, and which keys were used (e.g.
typesfor v11 were still used for v13 even though it should betypenow. As well as request in v13 needs to usecredential_definitionfor jwt vc json as well now, which in v11 was still top-level).