fix: sdjwtvc decode hasher dependency #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmzz, probably some tests will fail as this one has overlap with #118 |
|
@auer-martin Suggest to leave out the tx_code fix. We will then address that in #118 |
|
@nklomp done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two small problems.
In the VcIssuer file, the issuer is determined by decoding the credential into a standardized format with an issuer field.
Decoding the issuer requires a hash implementation for compact sdjwt's. To work around this, I made the issuer an argument.
The second problem concerns the implementation of token validation in combination with a PIN and compatibility with v11 and v13.