chore: working towards strict mode enabled for SIOP

jest.config.cjs

@@ -0,0 +1,38 @@
+module.exports = {
+    preset: "ts-jest",
+    testEnvironment: "node",
+    moduleNameMapper: {
+        "^jose/(.*)$": "<rootDir>/node_modules/.pnpm/[email protected]/node_modules/jose/dist/node/cjs/$1",
+    },
+    rootDir: ".",
+    // roots: ["<rootDir>/src/", "<rootDir>/test/"],
+    testMatch: ["**/?(*.)+(spec|test).+(ts|tsx|js)"],
+    transform: {
+        "^.+\\.(ts|tsx)?$": "ts-jest",
+    },
+    moduleFileExtensions: ["ts", "tsx", "js", "jsx", "json"],
+    coverageDirectory: "./coverage/",
+    collectCoverageFrom: [
+        "packages/**/src/**/*.ts",
+        "packages/**/lib/**/*.ts",
+        "!**/examples/**",
+        "!packages/cli/**",
+        "!**/types/**",
+        "!**/dist/**",
+        "!**/coverage/**",
+        "!**/node_modules/**/__tests__/**",
+        "!**/node_modules/**/*.test.ts",
+        "!**/node_modules/**",
+        "!**/packages/**/index.ts",
+        "!**/src/schemas/**",
+        "!**/src/**/*.d.ts",
+        "!jest.config.cjs",
+        "!**/generator/**",
+        "!index.ts",
+
+    ],
+    collectCoverage: true,
+    reporters: ["default", ["jest-junit", { outputDirectory: "./coverage" }]],
+    "automock": false,
+    "verbose": true
+};

jest.json

@@ -1,6 +1,7 @@
 {
   "preset": "ts-jest",
   "moduleFileExtensions": [
+    "js",
     "ts",
     "tsx",
     "js",

package.json

@@ -13,7 +13,7 @@
     "build": "pnpm -r --stream build",
     "build:clean": "lerna clean -y && pnpm install && lerna run build:clean --concurrency 1",
     "test:ci": "jest --config=jest.json",
-    "test": "jest --verbose --config=jest.json --coverage=true --detectOpenHandles",
+    "test": "jest --verbose --config=jest.json --coverage=true --detectOpenHandles  --maxWorkers=1",
     "clean": "rimraf --glob **/dist **/coverage **/pnpm-lock.yaml packages/**/node_modules node_modules packages/**/tsconfig.tsbuildinfo",
     "publish:latest": "lerna publish --conventional-commits --include-merged-tags --create-release github --yes --dist-tag latest --registry https://registry.npmjs.org",
     "publish:next": "lerna publish --conventional-prerelease --force-publish --canary --no-git-tag-version --include-merged-tags --preid next --pre-dist-tag next --yes --registry https://registry.npmjs.org",

packages/callback-example/tsconfig.json

@@ -3,17 +3,17 @@
   "compilerOptions": {
     "rootDir": "./lib",
     "outDir": "./dist",
-    "declarationDir": "./dist"
+    "declarationDir": "./dist",
   },
   "references": [
     {
-      "path": "../common"
+      "path": "../common",
     },
     {
-      "path": "../client"
+      "path": "../client",
     },
     {
-      "path": "../issuer"
-    }
-  ]
+      "path": "../issuer",
+    },
+  ],
 }

packages/client/lib/AccessTokenClient.ts

@@ -76,8 +76,8 @@ export class AccessTokenClient {
       metadata: metadata
         ? metadata
         : issuerOpts?.fetchMetadata
-        ? await MetadataClient.retrieveAllMetadata(issuerOpts.issuer, { errorOnNotFound: false })
-        : undefined,
+          ? await MetadataClient.retrieveAllMetadata(issuerOpts.issuer, { errorOnNotFound: false })
+          : undefined,
     });
 
     return this.sendAuthCode(requestTokenURL, accessTokenRequest);

packages/client/lib/CredentialOfferClient.ts

@@ -99,8 +99,8 @@ export class CredentialOfferClient {
       uriTypeProperties: isUri
         ? ['credential_offer_uri']
         : version >= OpenId4VCIVersion.VER_1_0_11
-        ? ['credential_issuer', 'credential_type']
-        : ['issuer', 'credential_type'],
+          ? ['credential_issuer', 'credential_type']
+          : ['issuer', 'credential_type'],
       param,
       version,
     });

packages/client/lib/OpenID4VCIClient.ts

@@ -340,8 +340,9 @@ export class OpenID4VCIClient {
       } else if (!response.successBody) {
         debug(`Access token error. No success body`);
         throw Error(
-          `Retrieving an access token from ${this._endpointMetadata
-            ?.token_endpoint} for issuer ${this.getIssuer()} failed as there was no success response body`,
+          `Retrieving an access token from ${
+            this._endpointMetadata?.token_endpoint
+          } for issuer ${this.getIssuer()} failed as there was no success response body`,
         );
       }
       this._accessTokenResponse = response.successBody;
@@ -459,8 +460,9 @@ export class OpenID4VCIClient {
     } else if (!response.successBody) {
       debug(`Credential request error. No success body`);
       throw Error(
-        `Retrieving a credential from ${this._endpointMetadata
-          ?.credential_endpoint} for issuer ${this.getIssuer()} failed as there was no success response body`,
+        `Retrieving a credential from ${
+          this._endpointMetadata?.credential_endpoint
+        } for issuer ${this.getIssuer()} failed as there was no success response body`,
       );
     }
     return response.successBody;

packages/client/lib/__tests__/AuthzFlowType.spec.ts

@@ -1,4 +1,4 @@
-import { AuthzFlowType, CredentialOfferPayload } from '@sphereon/oid4vc-common';
+import { AuthzFlowType, CredentialOfferPayload } from '../../../common/lib';
 
 //todo: this file is just testing v9, we probably want to add v11 tests here as well
 describe('Authorization Flow Type determination', () => {

packages/client/lib/__tests__/CredentialRequestClient.spec.ts

@@ -1,5 +1,11 @@
 import { KeyObject } from 'crypto';
 
+import * as jose from 'jose';
+// eslint-disable-next-line @typescript-eslint/ban-ts-comment
+// @ts-ignore
+import nock from 'nock';
+
+import { CredentialRequestClientBuilder, MetadataClient, ProofOfPossessionBuilder } from '..';
 import {
   Alg,
   EndpointMetadata,
@@ -10,13 +16,7 @@ import {
   ProofOfPossession,
   URL_NOT_VALID,
   WellKnownEndpoints,
-} from '@sphereon/oid4vc-common';
-import * as jose from 'jose';
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore
-import nock from 'nock';
-
-import { CredentialRequestClientBuilder, MetadataClient, ProofOfPossessionBuilder } from '..';
+} from '../../../common/lib';
 import { CredentialOfferClient } from '../CredentialOfferClient';
 
 import { IDENTIPROOF_ISSUER_URL, IDENTIPROOF_OID4VCI_METADATA, INITIATION_TEST, WALT_OID4VCI_METADATA } from './MetadataMocks';

packages/client/lib/__tests__/MetadataClient.spec.ts

@@ -1,8 +1,6 @@
-import { getIssuerFromCredentialOfferPayload, WellKnownEndpoints } from '@sphereon/oid4vc-common';
-// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-// @ts-ignore
 import nock from 'nock';
 
+import { getIssuerFromCredentialOfferPayload, WellKnownEndpoints } from '../../../common/lib';
 import { CredentialOfferClient } from '../CredentialOfferClient';
 import { MetadataClient } from '../MetadataClient';
 

packages/client/tsconfig.json

@@ -6,11 +6,11 @@
     "declarationDir": "dist",
     "esModuleInterop": true,
     "allowSyntheticDefaultImports": true,
-    "moduleResolution": "Node"
+    "moduleResolution": "Node",
   },
   "references": [
     {
-      "path": "../common"
-    }
-  ]
+      "path": "../common",
+    },
+  ],
 }

packages/common/tsconfig.json

@@ -5,6 +5,6 @@
     "outDir": "./dist",
     "declarationDir": "./dist",
     "esModuleInterop": true,
-    "moduleResolution": "Node"
-  }
+    "moduleResolution": "Node",
+  },
 }

packages/issuer-rest/lib/IssuerTokenEndpoint.ts

@@ -74,10 +74,15 @@ export const verifyTokenRequest = <T extends object>({
       })
     } catch (error) {
       if (error instanceof TokenError) {
-        return sendErrorResponse(response, error.statusCode, {
-          error: error.responseError,
-          error_description: error.getDescription(),
-        })
+        return sendErrorResponse(
+          response,
+          error.statusCode,
+          {
+            error: error.responseError,
+            error_description: error.getDescription(),
+          },
+          error,
+        )
       } else {
         return sendErrorResponse(response, 400, { error: TokenErrorResponse.invalid_request, error_description: (error as Error).message }, error)
       }

packages/issuer-rest/lib/__tests__/ClientIssuerIT.spec.ts

@@ -1,6 +1,15 @@
 import { KeyObject } from 'crypto'
 
 import * as didKeyDriver from '@digitalcredentials/did-method-key'
+import { VcIssuer } from '@sphereon/oid4vci-issuer/dist/VcIssuer'
+import { CredentialSupportedBuilderV1_11, VcIssuerBuilder } from '@sphereon/oid4vci-issuer/dist/builder'
+import { MemoryStates } from '@sphereon/oid4vci-issuer/dist/state-manager'
+import { ExpressBuilder, ExpressSupport } from '@sphereon/ssi-express-support'
+import { IProofPurpose, IProofType } from '@sphereon/ssi-types'
+import { DIDDocument } from 'did-resolver'
+import * as jose from 'jose'
+
+import { OpenID4VCIClient } from '../../../client/lib'
 import {
   AccessTokenResponse,
   Alg,
@@ -11,16 +20,7 @@ import {
   JWTHeader,
   JWTPayload,
   OpenId4VCIVersion,
-} from '@sphereon/oid4vc-common'
-import { OpenID4VCIClient } from '@sphereon/oid4vci-client'
-import { VcIssuer } from '@sphereon/oid4vci-issuer/dist/VcIssuer'
-import { CredentialSupportedBuilderV1_11, VcIssuerBuilder } from '@sphereon/oid4vci-issuer/dist/builder'
-import { MemoryStates } from '@sphereon/oid4vci-issuer/dist/state-manager'
-import { ExpressBuilder, ExpressSupport } from '@sphereon/ssi-express-support'
-import { IProofPurpose, IProofType } from '@sphereon/ssi-types'
-import { DIDDocument } from 'did-resolver'
-import * as jose from 'jose'
-
+} from '../../../common/lib'
 import { OID4VCIServer } from '../OID4VCIServer'
 
 const ISSUER_URL = 'http://localhost:3456/test'

packages/issuer-rest/tsconfig.json

@@ -4,14 +4,14 @@
     "rootDir": "./lib",
     "outDir": "./dist",
     "declarationDir": "./dist",
-    "esModuleInterop": true
+    "esModuleInterop": true,
   },
   "references": [
     {
-      "path": "../common"
+      "path": "../common",
     },
     {
-      "path": "../issuer"
-    }
-  ]
+      "path": "../issuer",
+    },
+  ],
 }

packages/issuer/lib/functions/CredentialOfferUtils.ts

@@ -49,6 +49,8 @@ export function createCredentialOfferObject(
   if (opts?.credentialOffer) {
     credential_offer = {
       ...opts.credentialOffer,
+      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+      // @ts-ignore
       credentials: opts.credentialOffer?.credentials ?? issuerMetadata?.credentials_supported,
     }
   } else {

packages/issuer/tsconfig.json

@@ -3,11 +3,11 @@
   "compilerOptions": {
     "rootDir": "./lib",
     "outDir": "./dist",
-    "declarationDir": "./dist"
+    "declarationDir": "./dist",
   },
   "references": [
     {
-      "path": "../common"
-    }
-  ]
+      "path": "../common",
+    },
+  ],
 }

packages/siopv2/README.md

@@ -369,7 +369,7 @@ const op = OP.builder()
     scopesSupported: [Scope.OPENID_DIDAUTHN, Scope.OPENID],
     subjectTypesSupported: [SubjectType.PAIRWISE],
     subjectSyntaxTypesSupported: ['did:ethr'],
-    passBy: PassBy.VALUE,
+    requestPassBy: PassBy.VALUE,
   })
   .build();
 ```

packages/siopv2/test/SdJwt.spec.ts → packages/siopv2/__tests__/SdJwt.spec.ts

@@ -4,6 +4,7 @@ import { IPresentationDefinition, SdJwtDecodedVerifiableCredentialWithKbJwtInput
 import { OriginalVerifiableCredential } from '@sphereon/ssi-types';
 import { IVerifyCallbackArgs, IVerifyCredentialResult } from '@sphereon/wellknown-dids-client';
 
+import { ResponseType } from '../../common/lib';
 import {
   OP,
   PassBy,
@@ -13,7 +14,6 @@ import {
   PresentationVerificationCallback,
   PropertyTarget,
   ResponseIss,
-  ResponseType,
   RevocationVerification,
   RP,
   Scope,

packages/siopv2/test/TestUtils.ts → packages/siopv2/__tests__/TestUtils.ts

@@ -9,14 +9,14 @@ import jwt_decode from 'jwt-decode';
 import moment from 'moment';
 import { v4 as uuidv4 } from 'uuid';
 
+import { ResponseType } from '../../common/lib';
 import {
   assertValidMetadata,
   base64ToHexString,
   DiscoveryMetadataPayload,
   KeyCurve,
   KeyType,
   ResponseIss,
-  ResponseType,
   RPRegistrationMetadataPayload,
   Scope,
   SigningAlgo,

packages/siopv2/test/spec-compliance/jwtVCPresentationProfile.spec.ts → packages/siopv2/__tests__/spec-compliance/jwtVCPresentationProfile.spec.ts

@@ -6,6 +6,7 @@ import { KeyLike } from 'jose';
 import nock from 'nock';
 import * as u8a from 'uint8arrays';
 
+import { ResponseType } from '../../../common/lib';
 import {
   AuthorizationRequest,
   AuthorizationResponse,
@@ -19,7 +20,6 @@ import {
   PresentationVerificationCallback,
   PropertyTarget,
   ResponseMode,
-  ResponseType,
   RevocationVerification,
   RP,
   SigningAlgo,