fix: set userPin back to fix current implementation

Signed-off-by: Mirko Mollik <[email protected]>
Sphereon-Opensource · Jul 16, 2024 · 43e7988 · 43e7988
1 parent e264b44
commit 43e7988
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/common/lib/types/StateManager.types.ts b/packages/common/lib/types/StateManager.types.ts
@@ -9,7 +9,8 @@ export interface CredentialOfferSession extends StateType {
   clientId?: string;
   credentialOffer: AssertedUniformCredentialOffer;
   credentialDataSupplierInput?: CredentialDataSupplierInput; // Optional storage that can help the credential Data Supplier. For instance to store credential input data during offer creation, if no additional data can be supplied later on
-  txCode?: string; // in here we only store the txCode, previously < V13 this was the userPin. We map the userPin onto this value
+  //txCode?: string; // in here we only store the txCode, previously < V13 this was the userPin. We map the userPin onto this value
+  userPin?: string; // in here we only store the userPin, previously < V13 this was the txCode. We map the txCode onto this value
   status: IssueStatus;
   error?: string;
   lastUpdatedAt: number;

diff --git a/packages/issuer/lib/tokens/index.ts b/packages/issuer/lib/tokens/index.ts
@@ -163,13 +163,13 @@ export const assertValidAccessTokenRequest = async (
         throw new TokenError(400, TokenErrorResponse.invalid_grant, `${PIN_VALIDATION_ERROR} ${txCodeOffer.length}`)
       }
     }
-    if (request.tx_code !== credentialOfferSession.txCode) {
+    if (request.tx_code !== credentialOfferSession.userPin) {
       throw new TokenError(400, TokenErrorResponse.invalid_grant, PIN_NOT_MATCH_ERROR)
     }
   } else if (request.user_pin) {
     if (!/[\\d]{1,8}/.test(request.user_pin)) {
       throw new TokenError(400, TokenErrorResponse.invalid_grant, `${PIN_VALIDATION_ERROR} 1-8`)
-    } else if (request.user_pin !== credentialOfferSession.txCode) {
+    } else if (request.user_pin !== credentialOfferSession.userPin) {
       throw new TokenError(400, TokenErrorResponse.invalid_grant, PIN_NOT_MATCH_ERROR)
     }
   }