Disable Semaphore and fix some flaky tests #157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: temporarily disable semaphore until we can iron out deadlocks
chore: some misc test fixes to fix flakiness
chore: fix an async function that wasn't async
Description
Motivation and Context
The semaphore in LdapConnectionPool appears to be causing a deadlock during heavy enumeration in certain edge cases. Until we can figure out whats causing it, we're disabling the behavior
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: