Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Semaphore and fix some flaky tests #157

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Disable Semaphore and fix some flaky tests #157

merged 4 commits into from
Aug 29, 2024

Conversation

rvazarkar
Copy link
Contributor

fix: temporarily disable semaphore until we can iron out deadlocks
chore: some misc test fixes to fix flakiness
chore: fix an async function that wasn't async

Description

Motivation and Context

The semaphore in LdapConnectionPool appears to be causing a deadlock during heavy enumeration in certain edge cases. Until we can figure out whats causing it, we're disabling the behavior

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@rvazarkar rvazarkar merged commit 3f8f147 into v4 Aug 29, 2024
3 checks passed
@rvazarkar rvazarkar deleted the disable_semaphore branch August 29, 2024 20:21
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants