Connections breakdowns #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <summary> | ||
| /// Checks the LDAP exception and throws an appropriate custom exception based on the error code. | ||
| /// </summary> | ||
| /// <param name="ldapException">The LDAP exception to check.</param> | ||
| private static void CheckAndThrowException(LdapException ldapException) |
There was a problem hiding this comment.
I don't know that I've actually done anything useful to the legibility of CheckAndThrowException I think I was just looking for an excuse to use a switch statement 🤷
| @@ -1498,7 +1525,6 @@ private string ResolveDomainToFullName(string domain) | |||
| /// <param name="authType">Auth type to use. Defaults to Kerberos. Use Negotiate for netonly/cross trust(forest) scenarios</param> | |||
| /// <param name="globalCatalog">Use global catalog or not</param> | |||
| /// <returns>A connected LDAP connection or null</returns> | |||
|
|
|||
| private async Task<LdapConnectionWrapper> CreateLDAPConnectionWrapper(string domainName = null, bool skipCache = false, | |||
There was a problem hiding this comment.
CreateLDAPConnectionWrapper is still a bit of a monolith, I'll want to iterate this one again.
| return true; | ||
| } | ||
|
|
||
| private void HandleBusyException(ref int retryCount, ref TimeSpan backoffDelay) |
There was a problem hiding this comment.
Not the biggest fan of using refs. Will iterate this and try to remove, but for now I think the current design is simple enough to justify their use here.
| } | ||
|
|
||
| CheckAndThrowException(connectionResult.Exception); | ||
| return null; |
There was a problem hiding this comment.
Per our new strategy, I should switch this to return a bool and out var
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A first pass at breaking down monolithic DC connection methods in LDAPUtils
Motivation and Context
Hopefully makes things more legible, testable and maintainable.
How Has This Been Tested?
Will be tested locally
Screenshots (if appropriate):
Types of changes
Checklist: