-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support archival queries by modifying the WorkingSet #1184
Conversation
Codecov Report
Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good – I'd just like to make sure that we're not accumulating too much tech debt with this change, since it doesn't replace all instances of WorkingSet
with generics so it leaves things in a somewhat messy state. With the addition of ArchivalWorkingSet
, we also have too many WorkingSet
-like structs – although that's definitely not this PR's fault. Let's brainstorm at standup!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me. I don't see any blockers to integrating fork management into it.
Changes in sov-db
are not entierly new, native db just gets same functionality as state_db already has.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would it be possible to add more tests in sov-modules-code/tests
? (In a separate PR)
Description
This accomplishes support for archival / versioned queries against state-db and native-db. This is similar to #1170 but instead of modifying the Storage level, this modification is at the WorkingSet level
Linked Issues