Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow open redirect for Rails 7.0 in #redirect_back_or_to method #351

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Allow open redirect for Rails 7.0 in #redirect_back_or_to method #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c856d4e
Allow open redirect for Rails 7.0
berkos Oct 26, 2023
3d9b68a
Update CHANGELOG.md
berkos Oct 26, 2023
26c7f95
Merge branch 'master' into rails-7.0-redirect-fix
joshbuker Mar 8, 2024
db56b65
Merge branch 'master' into rails-7.0-redirect-fix
berkos Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# Changelog
## HEAD

* Allow open redirect for Rails 7.0 in #redirect_back_or_to method [#351](https://github.com/Sorcery/sorcery/pull/351)

## 0.17.0

* Fix Rails 7.1 compatibility by using `ActiveRecord.timestamped_migrations` [#352](https://github.com/Sorcery/sorcery/pull/352)
Expand Down
2 changes: 1 addition & 1 deletion lib/sorcery/controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def current_user=(user)
# used when a user tries to access a page while logged out, is asked to login,
# and we want to return him back to the page he originally wanted.
def redirect_back_or_to(url, flash_hash = {})
redirect_to(session[:return_to_url] || url, flash: flash_hash)
redirect_to(session[:return_to_url] || url, flash: flash_hash, allow_other_host: true)
Comment on lines 100 to +101
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The redirect_back_or_to method, unlike what's described in #318, might accept user input depending on how it's used. Therefore, it would be more secure and preferable to not set allow_other_host to true by default, but rather, to provide it as an argument.

session[:return_to_url] = nil
end

Expand Down