Set secure flag for remember_me cookie #295
Open
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, so this allows users to set secure cookies to true without needing Just to sanity check, @paderinandrey does your use-case prevent you from using |
joshbuker
requested changes
Dec 6, 2021
| @@ -71,7 +71,8 @@ def set_remember_me_cookie!(user) | |||
| value: user.send(user.sorcery_config.remember_me_token_attribute_name), | |||
| expires: user.send(user.sorcery_config.remember_me_token_expires_at_attribute_name), | |||
| httponly: Config.remember_me_httponly, | |||
| domain: Config.cookie_domain | |||
| domain: Config.cookie_domain, | |||
| secure: Config.remember_me_secure | |||
There was a problem hiding this comment.
I'd be worried that this has the potential to overwrite the default of secure: true when using force_ssl. We'll need to double check that interaction before merging this in. Ideally, adding a test or two.
| def merge_remember_me_defaults! | ||
| @defaults.merge!(:@remember_me_httponly => true) | ||
| @defaults.merge!(:@remember_me_httponly => true, :@remember_me_secure => false) |
There was a problem hiding this comment.
nil would likely be a safer default here. Still would need to sanity check how this interacts with force_ssl either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to set the secure flag for the remember_me cookie
Please ensure your pull request includes the following: