Fix USB remote wakeup #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this with my keychron k4 v2 and at least I can wake up my pc now with the keyboard. But if the wakeup happens with a mouse click, the keyboard still doesn't turn on, without a key press. An improvement nonetheless, thank you |
dexter93
reviewed
Nov 25, 2022
dexter93
reviewed
Nov 25, 2022
Co-authored-by: dexter93 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing this 2 ms sleep to a busywait fixes USB remote wakeup on my Keychron C1 (white backlight version, 260). The old implementation of remote wakeup (from the now-removed usbhw.c) also busywaited instead of sleeping, so this is probably the correct solution and unlikely to cause problems.