Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLI-1812 Support for Ansible files #1290

Merged
merged 1 commit into from
Jan 28, 2025
Merged

SLI-1812 Support for Ansible files #1290

merged 1 commit into from
Jan 28, 2025

Conversation

eray-felek-sonarsource
Copy link
Contributor

@eray-felek-sonarsource eray-felek-sonarsource commented Jan 27, 2025 •
edited by jira bot
Loading

@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/SLI-1812-ansible-support branch 2 times, most recently from 1ad698e to 1c13690 Compare January 28, 2025 08:54
nquinquenel
nquinquenel requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@nquinquenel nquinquenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a UI test for Ansible, as we do for most language we support in SQ:IJ

@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/SLI-1812-ansible-support branch 2 times, most recently from 262502e to 40bb1e4 Compare January 28, 2025 10:47
@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/SLI-1812-ansible-support branch from 40bb1e4 to 9e54b12 Compare January 28, 2025 14:02
nquinquenel
nquinquenel approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@nquinquenel nquinquenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@eray-felek-sonarsource eray-felek-sonarsource merged commit c16b3af into master Jan 28, 2025
30 checks passed
@eray-felek-sonarsource eray-felek-sonarsource deleted the feature/ef/SLI-1812-ansible-support branch January 28, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource sophio-japharidze-sonarsource approved these changes

@nquinquenel nquinquenel nquinquenel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eray-felek-sonarsource @nquinquenel @sophio-japharidze-sonarsource