SLCORE-941: Don't fail on Windows Shortcuts #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thahnen
force-pushed
the
bug/tha/SLCORE-941_Shortcut
branch
2 times, most recently
from
b6494f1 to
4b357ac
Compare
Following the Windows specification we have to exclude Windows Shortcuts from the analysis as they are no links but actual, binary files. The exclusion check if the file name hints to be a shortcut based on its extension. Only then we check the magic number and decide based on it.
thahnen
force-pushed
the
bug/tha/SLCORE-941_Shortcut
branch
from
4b357ac to
e0efbdb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLCORE-941
Following the Windows specification we have to exclude Windows Shortcuts from the analysis as they are no links but actual, binary files.
The exclusion checks if the file name hints to be a shortcut based on its extension. Only then do we check the magic number and decide based on it.