Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLCORE-938 + SLCORE-940 Implement telemetry metrics system #1095

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

jblievremont
Copy link
Member

@jblievremont jblievremont commented Sep 6, 2024

@jblievremont jblievremont changed the title SLCORE-938 Implement telemetry metrics system for shared connected mode settings SLCORE-938 + SLCORE-940 Implement telemetry metrics system Sep 9, 2024
@jblievremont jblievremont marked this pull request as ready for review September 9, 2024 14:11
Copy link
Contributor

@kirill-knize-sonarsource kirill-knize-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Comment:
I have noticed many values of enums that are currently not being used.
Usually we avoid adding code "for future use" or "just in case" because there's a risk that plans will change and it will become a dead code.
I understand it's a first step of improvements for the telemetry, but the spec was not detailed enough to tell we really need all these enum values. Hopefully, these changes are well thought.
Approving PR anyway.

@jblievremont
Copy link
Member Author

Yup, the enum values reflect the current state of the telemetry metrics ADR; even though we don't need them at the moment, I consider good practice to implement the full protocol.

@jblievremont jblievremont merged commit f0706e8 into master Sep 12, 2024
13 checks passed
@jblievremont jblievremont deleted the SLCORE-938-telemetry-metrics-for-shared-settings branch September 12, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants