Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCCPPGHA-8 Make use of the Linux ARM64 CLI Scanner #59

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

friedbyalice
Copy link
Contributor

@friedbyalice friedbyalice commented Jun 27, 2024

List of checkpoint to verify/do before merging a PR.

Dev checklist

  • Write/update tests
  • Functional validation
  • Public documentation update
  • Private documentation update
  • Clean commits (should start with a ticket number, clear message, no fixup, wip)
  • Maximize code coverage as much as possible

Reviewer checklist

  • Code review
  • Functional validation
  • Check commits are clean

Steps to validate this PR

Fill-in how you performed the validation, and how the reviewer can replicate it:

  • Run on fork of sonar-cfamily-examples
    linux here for Linux X64 and ARM64.
    windows here
    macos here. Notice how an ARM64 jre is provisioned, where in the previous run an x64 was provisioned. This means that performance is potentially improved, both for us and for other analyzers that could get run

@friedbyalice friedbyalice force-pushed the vp/nativeCli branch 2 times, most recently from 339de17 to 3bfce34 Compare June 27, 2024 09:16
@friedbyalice friedbyalice changed the title Use native scanner Use platform specific scanner Jun 27, 2024
@friedbyalice friedbyalice changed the title Use platform specific scanner SCCPPGHA-8 Make use of the Linux ARM64 CLI Scanner Jun 27, 2024
Copy link
Contributor

@michael-jabbour-sonarsource michael-jabbour-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left one comment.

Have you validated this change by running analyses on Linux aarch64 using the current onboarding page content? I would expect that we only need to change the version of the used action and it should work...

@friedbyalice
Copy link
Contributor Author

friedbyalice commented Jun 28, 2024

Validated

  • linux here for Linux X64 and ARM64.
  • windows here
  • macos here. Notice how an ARM64 jre is provisioned, where in the previous run an x64 was provisioned. This means that performance is potentially improved, both for us and for other analyzers that could get run

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of these changes. Could you ask AE for the final review before we merge?

@7PH 7PH self-requested a review July 2, 2024 15:32
Copy link
Member

@7PH 7PH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@friedbyalice friedbyalice merged commit 1748dd0 into main Jul 3, 2024
12 checks passed
@michael-jabbour-sonarsource michael-jabbour-sonarsource deleted the vp/nativeCli branch July 10, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants