-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCCPPGHA-8 Make use of the Linux ARM64 CLI Scanner #59
Conversation
339de17
to
3bfce34
Compare
c05c1d0
to
cb4779a
Compare
e97d80f
to
cb4779a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left one comment.
Have you validated this change by running analyses on Linux aarch64 using the current onboarding page content? I would expect that we only need to change the version of the used action and it should work...
11e5ed9
to
d79c828
Compare
eb227a8
to
1c34a75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for taking care of these changes. Could you ask AE for the final review before we merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
List of checkpoint to verify/do before merging a PR.
Dev checklist
Reviewer checklist
Steps to validate this PR
Fill-in how you performed the validation, and how the reviewer can replicate it:
linux here for Linux X64 and ARM64.
windows here
macos here. Notice how an ARM64 jre is provisioned, where in the previous run an x64 was provisioned. This means that performance is potentially improved, both for us and for other analyzers that could get run