Prevent globbing and word splitting #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoine-vinot-sonarsource
requested changes
Jul 12, 2024
There was a problem hiding this comment.
Hi @vil02!
Thank you for your contribution!
Our QA is failing mainly due to quoting the debug flag and the input args.
I've added a comment on the line.
antoine-vinot-sonarsource
approved these changes
Jul 12, 2024
antoine-vinot-sonarsource
merged commit f4a7a62
into
SonarSource:master
8 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not using double quotes here might cause globbing and word splitting (cf. SC2086).
Similar to SonarSource/sonarcloud-github-c-cpp#60.