Drop GH token from README #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claire-villard-sonarsource
removed the request for review
from nawar-hamo-sonarsource
henryju
force-pushed
the
feature/bogdana/SC-6818-github-token
branch
from
de12c4a to
3073358
Compare
henryju
approved these changes
May 23, 2024
|
Any context for this? Is GITHUB_TOKEN no longer necessary to be passed? https://github.com/SonarSource/sonarcloud-github-action#secrets still refers to GITHUB_TOKEN which just increases confusion. Nothing in the release notes to explain anything https://github.com/SonarSource/sonarcloud-github-action/releases/tag/v2.2 |
|
It might have been necessary a long time ago for PR decoration, but we could not find a use case for it anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.