Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARIAC-1312 S6897: Should not raise with LimitRange in the same namespace setting Storage Requests #1389

Merged
merged 5 commits into from
Jun 28, 2024
Merged

SONARIAC-1312 S6897: Should not raise with LimitRange in the same namespace setting Storage Requests #1389

merged 5 commits into from
Jun 28, 2024

Conversation

jonas-wielage-sonarsource
Copy link
Contributor

@jonas-wielage-sonarsource jonas-wielage-sonarsource commented Jun 28, 2024 •
edited
Loading

@jonas-wielage-sonarsource jonas-wielage-sonarsource force-pushed the SONARIAC-1312 branch 3 times, most recently from 31053d1 to 480a309 Compare June 28, 2024 13:02
petertrr
petertrr approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...ubernetes/src/main/java/org/sonar/iac/kubernetes/checks/AbstractResourceManagementCheck.java Outdated Show resolved Hide resolved
@jonas-wielage-sonarsource jonas-wielage-sonarsource enabled auto-merge (squash) June 28, 2024 13:40
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jonas-wielage-sonarsource jonas-wielage-sonarsource merged commit 1a9088b into master Jun 28, 2024
9 checks passed
@jonas-wielage-sonarsource jonas-wielage-sonarsource deleted the SONARIAC-1312 branch June 28, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertrr petertrr petertrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonas-wielage-sonarsource @petertrr