Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NET-915 Modify rule S2930: Include tracked types in the description #4588

Merged
merged 1 commit into from
Dec 23, 2024
Merged

NET-915 Modify rule S2930: Include tracked types in the description #4588

merged 1 commit into from
Dec 23, 2024

Conversation

sebastien-marichal
Copy link
Contributor

@sebastien-marichal sebastien-marichal commented Dec 23, 2024 •
edited by jira bot
Loading

NET-915

Part of NET-255

Fixes SonarSource/sonar-dotnet#8141

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

CristianAmbrosini
CristianAmbrosini approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@CristianAmbrosini CristianAmbrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CristianAmbrosini CristianAmbrosini merged commit f96f4c8 into master Dec 23, 2024
12 checks passed
@CristianAmbrosini CristianAmbrosini deleted the sma/modify-S2930 branch December 23, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CristianAmbrosini CristianAmbrosini CristianAmbrosini approved these changes

Assignees
No one assigned
Labels
dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve S2930: Update RSPEC by describing which types are tracked
2 participants
@sebastien-marichal @CristianAmbrosini