Modify rule S1075: Add more exceptions (SONARJAVA-5149) #4570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorian-burihabwa-sonarsource
changed the title
dorian-burihabwa-sonarsource
changed the title
dorian-burihabwa-sonarsource
requested changes
Dec 11, 2024
rules/S1075/java/rule.adoc
Outdated
| @@ -1,5 +1,13 @@ | |||
| include::../description.adoc[] | |||
|
|
|||
| === Exceptions | |||
|
|
|||
| This rules doesn't raise an issue when: | |||
There was a problem hiding this comment.
Suggested change
| This rules doesn't raise an issue when: | |
| This rule does not raise an issue when: |
rules/S1075/java/rule.adoc
Outdated
|
|
||
| This rules doesn't raise an issue when: | ||
|
|
||
| * A relative URI is declared in a static final constant and the URI contains at most two parts. |
There was a problem hiding this comment.
It might be good to provide an example if we do not already have one in the samples
rules/S1075/java/rule.adoc
Outdated
Comment on lines
8
to
9
| * An URI is declared in a static final constant and the constant is used in an annotation. | ||
| * An URI is declared in a variable annotated with an annotation. |
There was a problem hiding this comment.
Suggested change
| * An URI is declared in a static final constant and the constant is used in an annotation. | |
| * An URI is declared in a variable annotated with an annotation. | |
| * A URI is declared in a static final constant and the constant is used in an annotation. | |
| * A URI is declared in a variable annotated with an annotation. |
dorian-burihabwa-sonarsource
approved these changes
Dec 16, 2024
dorian-burihabwa-sonarsource
force-pushed
the
erwan/modify-S1075
branch
from
27188c7 to
ce92faa
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review
A dedicated reviewer checked the rule description successfully for: