Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify rule S6984: Update einsum link #4565

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Modify rule S6984: Update einsum link #4565

merged 1 commit into from
Dec 10, 2024

Conversation

joke1196
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

ghislainpiot
ghislainpiot approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@ghislainpiot ghislainpiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
The original site works on my computer though?

@ghislainpiot ghislainpiot merged commit 92e1462 into master Dec 10, 2024
11 of 12 checks passed
@ghislainpiot ghislainpiot deleted the dk/update-link-s6984 branch December 10, 2024 13:15
@joke1196
Copy link
Contributor Author

Yes it does work still but it is not trusted by Fortinet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghislainpiot ghislainpiot ghislainpiot approved these changes

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joke1196 @ghislainpiot