Modify rule S6932: Update code example #4563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
requested a review
from martin-strecker-sonarsource
mary-georgiou-sonarsource
force-pushed
the
mary/rule-S6932
branch
from
b0c4613 to
fbcd0ba
Compare
martin-strecker-sonarsource
requested changes
Dec 10, 2024
rules/S6932/csharp/rule.adoc
Outdated
Comment on lines
166
to
170
| public IActionResult Post() | ||
| { | ||
| var origin = Request.Headers[HeaderNames.Origin]; // Compliant: Access via variable | ||
| var name = Request.Form["name"]; // Compliant: Access via constant and variable keys is mixed | ||
| var birthdate = DateTime.Parse(Request.Form["Birthdate"]); // Compliant: Access via constant and variable keys is mixed |
There was a problem hiding this comment.
Suggested change
| public IActionResult Post() | |
| { | |
| var origin = Request.Headers[HeaderNames.Origin]; // Compliant: Access via variable | |
| var name = Request.Form["name"]; // Compliant: Access via constant and variable keys is mixed | |
| var birthdate = DateTime.Parse(Request.Form["Birthdate"]); // Compliant: Access via constant and variable keys is mixed | |
| public IActionResult Post() | |
| { | |
| var origin = Request.Headers[HeaderNames.Origin]; // Compliant: Access via non-constant field | |
| var nameField = "name"; | |
| var name = Request.Form[nameField]; // Compliant: Access via local | |
| var birthdate = DateTime.Parse(Request.Form["Birthdate"]); // Compliant: Access via constant and variable keys is mixed. | |
| // Model binding would only work partially in the method, so we do not raise here. | |
| return Ok(); |
Co-authored-by: Martin Strecker <[email protected]>
mary-georgiou-sonarsource
requested a review
from martin-strecker-sonarsource
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.