Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate rule S5742 #4561

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Deprecate rule S5742 #4561

merged 2 commits into from
Dec 9, 2024

Conversation

hendrik-buchwald-sonarsource
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource added the javascript Pull requests that update Javascript code label Dec 6, 2024
Copy link

sonarqube-next bot commented Dec 6, 2024

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

sonarqube-next bot commented Dec 6, 2024

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource merged commit d1ee5fd into master Dec 9, 2024
9 of 10 checks passed
@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource deleted the appsec-1369 branch December 9, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants