-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SONARPLSQL-805 S3921: Update RSPEC to mention data dictionary #4544
Conversation
dc6f324
to
adb964c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good improvements, very nice!
Just a few minor comments.
Did you find an easy way to list all rules which use the data dictionary? |
All the rule that use data dictionary override a method, that's how I did it. |
6c62619
to
df82395
Compare
Quality Gate passed for 'rspec-tools'Issues Measures |
Quality Gate passed for 'rspec-frontend'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SONARPLSQL-805
I have updated to LaYC format the other data dictionary rules as I modified them:
Each rule update is its own commit.