Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARPLSQL-805 S3921: Update RSPEC to mention data dictionary #4544

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

sebastien-marichal
Copy link
Contributor

@sebastien-marichal sebastien-marichal commented Nov 27, 2024

SONARPLSQL-805

I have updated to LaYC format the other data dictionary rules as I modified them:

  • S3618
  • S3641
  • S3651
  • S3921

Each rule update is its own commit.

Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good improvements, very nice!
Just a few minor comments.

rules/S3618/plsql/rule.adoc Outdated Show resolved Hide resolved
rules/S3641/how.adoc Outdated Show resolved Hide resolved
rules/S3651/plsql/rule.adoc Show resolved Hide resolved
rules/S3651/plsql/rule.adoc Outdated Show resolved Hide resolved
@Tim-Pohlmann
Copy link
Contributor

Did you find an easy way to list all rules which use the data dictionary?

@sebastien-marichal
Copy link
Contributor Author

All the rule that use data dictionary override a method, that's how I did it.

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tim-Pohlmann Tim-Pohlmann merged commit 0a7e283 into master Nov 27, 2024
11 checks passed
@Tim-Pohlmann Tim-Pohlmann deleted the sma/plsql-805 branch November 27, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants