-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify rule S6249: fix Terraform code examples #4502
Conversation
Principal = [ | ||
"arn:aws:iam::123456789123:root" | ||
] # secondary location: only one principal is forced to use https | ||
Principal = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous code example was "right" too, but we're not currently detecting it with our rule implementation.
This change ensures that we're documenting a case that is working with our current implementation, while the implementation itself will be updated in other tickets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pasting the noncompliant example does not raise an issue in the current implementation (if I didn't do any mistake)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, was a mistake on my setup.
Quality Gate passed for 'rspec-tools'Issues Measures |
Quality Gate passed for 'rspec-frontend'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the PR title to reflect the RSPEC guidelines.
"Modify rule S6249: ..."
Principal = [ | ||
"arn:aws:iam::123456789123:root" | ||
] # secondary location: only one principal is forced to use https | ||
Principal = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pasting the noncompliant example does not raise an issue in the current implementation (if I didn't do any mistake)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Principal = [ | ||
"arn:aws:iam::123456789123:root" | ||
] # secondary location: only one principal is forced to use https | ||
Principal = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, was a mistake on my setup.
Review
A dedicated reviewer checked the rule description successfully for: