Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify rule S6249: fix Terraform code examples #4502

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

GabinL21
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@GabinL21 GabinL21 added the iac label Nov 14, 2024
@GabinL21 GabinL21 self-assigned this Nov 14, 2024
@GabinL21 GabinL21 changed the title Improve rule S6249: fix Terraform code examples SONARIAC-376 Improve rule S6249: fix Terraform code examples Nov 14, 2024
Principal = [
"arn:aws:iam::123456789123:root"
] # secondary location: only one principal is forced to use https
Principal = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous code example was "right" too, but we're not currently detecting it with our rule implementation.

This change ensures that we're documenting a case that is working with our current implementation, while the implementation itself will be updated in other tickets.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pasting the noncompliant example does not raise an issue in the current implementation (if I didn't do any mistake)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, was a mistake on my setup.

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@jonas-wielage-sonarsource jonas-wielage-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the PR title to reflect the RSPEC guidelines.
"Modify rule S6249: ..."

Principal = [
"arn:aws:iam::123456789123:root"
] # secondary location: only one principal is forced to use https
Principal = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pasting the noncompliant example does not raise an issue in the current implementation (if I didn't do any mistake)

Copy link
Contributor

@jonas-wielage-sonarsource jonas-wielage-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Principal = [
"arn:aws:iam::123456789123:root"
] # secondary location: only one principal is forced to use https
Principal = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, was a mistake on my setup.

@GabinL21 GabinL21 changed the title SONARIAC-376 Improve rule S6249: fix Terraform code examples SONARIAC-376 Modify rule S6249: fix Terraform code examples Nov 14, 2024
@GabinL21 GabinL21 changed the title SONARIAC-376 Modify rule S6249: fix Terraform code examples Modify rule S6249: fix Terraform code examples Nov 14, 2024
@GabinL21 GabinL21 merged commit 19f97f6 into master Nov 14, 2024
10 of 11 checks passed
@GabinL21 GabinL21 deleted the fix-examples-S6249-terraform branch November 14, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants